Seperate temperature probes #16

JHSawatzki · 2024-05-29T09:45:42Z

Fixes Issue #14

…erature probes (RTD and TC)

… to double precision

…nd RTD

CLAassistant · 2024-05-29T09:45:48Z

All committers have signed the CLA.

# Conflicts: # src/utility/MAX31865/MAX31865.cpp # src/utility/MAX31865/MAX31865.h

JHSawatzki · 2024-05-29T11:13:41Z

Sorry for the spelling error. I was reading an 'n' instead of the second 'm'.

Seperate temperature probes

github-actions · 2024-05-29T11:52:56Z

Memory usage change @ 907a450

Board	flash	%	RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A

Click for full report table

Board	`examples/Analog_Out` flash	%	`examples/Analog_Out` RAM for global variables	%	`examples/Analog_input/Analog_input_0_10V` flash	%	`examples/Analog_input/Analog_input_0_10V` RAM for global variables	%	`examples/Analog_input/Analog_input_4_20mA` flash	%	`examples/Analog_input/Analog_input_4_20mA` RAM for global variables	%	`examples/Analog_input/Analog_input_NTC` flash	%	`examples/Analog_input/Analog_input_NTC` RAM for global variables	%	`examples/Analog_input/Fast_Analog_input_0_10V` flash	%	`examples/Analog_input/Fast_Analog_input_0_10V` RAM for global variables	%	`examples/CAN/ReadCan` flash	%	`examples/CAN/ReadCan` RAM for global variables	%	`examples/CAN/WriteCan` flash	%	`examples/CAN/WriteCan` RAM for global variables	%	`examples/Digital_output` flash	%	`examples/Digital_output` RAM for global variables	%	`examples/Digital_programmable/Digital_input` flash	%	`examples/Digital_programmable/Digital_input` RAM for global variables	%	`examples/Digital_programmable/GPIO_programmable` flash	%	`examples/Digital_programmable/GPIO_programmable` RAM for global variables	%	`examples/Encoders` flash	%	`examples/Encoders` RAM for global variables	%	`examples/Ethernet` flash	%	`examples/Ethernet` RAM for global variables	%	`examples/RS232` flash	%	`examples/RS232` RAM for global variables	%	`examples/RS485_fullduplex` flash	%	`examples/RS485_fullduplex` RAM for global variables	%	`examples/RS485_halfduplex` flash	%	`examples/RS485_halfduplex` RAM for global variables	%	`examples/RTC` flash	%	`examples/RTC` RAM for global variables	%	`examples/RTC_Alarm` flash	%	`examples/RTC_Alarm` RAM for global variables	%	`examples/Temp_probes_Mixed` flash	%	`examples/Temp_probes_Mixed` RAM for global variables	%	`examples/Temp_probes_RTD` flash	%	`examples/Temp_probes_RTD` RAM for global variables	%	`examples/Temp_probes_Thermocouples` flash	%	`examples/Temp_probes_Thermocouples` RAM for global variables	%	`examples/USB_host` flash	%	`examples/USB_host` RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/Analog_input/Fast_Analog_input_0_10V<br>flash,%,examples/Analog_input/Fast_Analog_input_0_10V<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_Mixed<br>flash,%,examples/Temp_probes_Mixed<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

Copyright header removed

github-actions · 2024-06-03T08:52:02Z

Memory usage change @ dd66851

Board	flash	%	RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A

Click for full report table

Board	`examples/Analog_Out` flash	%	`examples/Analog_Out` RAM for global variables	%	`examples/Analog_input/Analog_input_0_10V` flash	%	`examples/Analog_input/Analog_input_0_10V` RAM for global variables	%	`examples/Analog_input/Analog_input_4_20mA` flash	%	`examples/Analog_input/Analog_input_4_20mA` RAM for global variables	%	`examples/Analog_input/Analog_input_NTC` flash	%	`examples/Analog_input/Analog_input_NTC` RAM for global variables	%	`examples/Analog_input/Fast_Analog_input_0_10V` flash	%	`examples/Analog_input/Fast_Analog_input_0_10V` RAM for global variables	%	`examples/CAN/ReadCan` flash	%	`examples/CAN/ReadCan` RAM for global variables	%	`examples/CAN/WriteCan` flash	%	`examples/CAN/WriteCan` RAM for global variables	%	`examples/Digital_output` flash	%	`examples/Digital_output` RAM for global variables	%	`examples/Digital_programmable/Digital_input` flash	%	`examples/Digital_programmable/Digital_input` RAM for global variables	%	`examples/Digital_programmable/GPIO_programmable` flash	%	`examples/Digital_programmable/GPIO_programmable` RAM for global variables	%	`examples/Encoders` flash	%	`examples/Encoders` RAM for global variables	%	`examples/Ethernet` flash	%	`examples/Ethernet` RAM for global variables	%	`examples/RS232` flash	%	`examples/RS232` RAM for global variables	%	`examples/RS485_fullduplex` flash	%	`examples/RS485_fullduplex` RAM for global variables	%	`examples/RS485_halfduplex` flash	%	`examples/RS485_halfduplex` RAM for global variables	%	`examples/RTC` flash	%	`examples/RTC` RAM for global variables	%	`examples/RTC_Alarm` flash	%	`examples/RTC_Alarm` RAM for global variables	%	`examples/Temp_probes_Mixed` flash	%	`examples/Temp_probes_Mixed` RAM for global variables	%	`examples/Temp_probes_RTD` flash	%	`examples/Temp_probes_RTD` RAM for global variables	%	`examples/Temp_probes_Thermocouples` flash	%	`examples/Temp_probes_Thermocouples` RAM for global variables	%	`examples/USB_host` flash	%	`examples/USB_host` RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/Analog_input/Fast_Analog_input_0_10V<br>flash,%,examples/Analog_input/Fast_Analog_input_0_10V<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_Mixed<br>flash,%,examples/Temp_probes_Mixed<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

leonardocavagnis · 2024-10-23T12:25:15Z

Thanks for submitting your solution, but we decided to not separate them.

JHSawatzki added 19 commits May 22, 2024 16:36

Reformating MAX31855 class

8895f39

Further code formating in MAX31855 class

a45f5ed

Minor code formating and spelling fixes

b69fd34

Minor fixes and removing global object definition for MAX31855

07b3f95

Preparation for multi probe setups and shared implementation for temp…

aaa8ec4

…erature probes (RTD and TC)

Renaming folder MAX31865 to RTD

91f1d8b

Adding type T TC probe type

f534edf

Add ability to retrieve the TC fault cause

f243a01

Renaming coldTempTomv to tempTomv

667bb15

Code formating and readability improvements

4fe00ca

Added ability to read TC voltage. Also changed return type from float…

4a63b8f

… to double precision

Getter functions fro parameters added

952590a

Formating of MAX31865Class

76f88a0

Further code formating

6d97927

Changed SPI communication to be equal to MAX31855Class

f15e881

Minor typo fixed

21175b4

readBytes renamed to readWord

11655b6

Changes for multi probe (different types) and shared library for TC a…

f69ca1a

…nd RTD

Introduction of shared TempProbeClass

f3d9cdd

Merge branch 'iabg' into seperate-temperature-probes

907a450

# Conflicts: # src/utility/MAX31865/MAX31865.cpp # src/utility/MAX31865/MAX31865.h

Merge pull request #1 from JHSawatzki/seperate-temperature-probes

383b9a4

Seperate temperature probes

JHSawatzki added 2 commits June 3, 2024 10:05

Remove artifacts, Thermocouple type-t corrections and typo corrected

f0eec75

Merge branch 'iabg' into seperate-temperature-probes

dd66851

Copyright header removed

leonardocavagnis added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure topic: code Related to content of the project itself labels Jun 3, 2024

leonardocavagnis linked an issue Jun 3, 2024 that may be closed by this pull request

Separation of RTD and TC classes confusing #14

Closed

leonardocavagnis closed this Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Seperate temperature probes #16

Seperate temperature probes #16

JHSawatzki commented May 29, 2024

CLAassistant commented May 29, 2024 •

edited

Loading

JHSawatzki commented May 29, 2024

github-actions bot commented May 29, 2024

github-actions bot commented Jun 3, 2024

leonardocavagnis commented Oct 23, 2024

Seperate temperature probes #16

Seperate temperature probes #16

Conversation

JHSawatzki commented May 29, 2024

CLAassistant commented May 29, 2024 • edited Loading

JHSawatzki commented May 29, 2024

github-actions bot commented May 29, 2024

github-actions bot commented Jun 3, 2024

leonardocavagnis commented Oct 23, 2024

CLAassistant commented May 29, 2024 •

edited

Loading