Skip to content

Apply adjustments from the library review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 11 additions & 37 deletions .github/workflows/compile-examples.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Source: https://github.com/per1234/.github/blob/main/workflow-templates/compile-examples-private.md
name: Compile Examples

# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
Expand All @@ -22,9 +23,9 @@ on:

env:
UNIVERSAL_SKETCH_PATHS: |
- examples/Battery
- examples/Charger
- examples/Standby_WakeFromPin
- examples/Battery
- examples/Charger
- examples/Standby_WakeFromPin
SKETCHES_REPORTS_PATH: sketches-reports
SKETCHES_REPORTS_ARTIFACT_NAME: sketches-reports

Expand All @@ -41,18 +42,17 @@ jobs:

matrix:
board:
- fqbn: arduino:renesas_portenta:portenta_c33
platforms: |
- name: arduino:renesas_portenta
artifact-name-suffix: arduino-renesas_portenta-portenta_c33
additional-sketch-paths: examples/ChargStandby_WakeFromRTC_C33er
- fqbn: arduino:mbed_portenta:envie_m7
platforms: |
- name: arduino:mbed_portenta
artifact-name-suffix: arduino-mbed_portenta-envie_m7
additional-sketch-paths: examples/Standby_WakeFromRTC_C33
- fqbn: arduino:renesas_portenta:portenta_c33
platforms: |
- name: arduino:renesas_portenta
artifact-name-suffix: arduino-renesas_portenta-portenta_c33
additional-sketch-paths: examples/Standby_WakeFromRTC_H7


steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand All @@ -64,10 +64,8 @@ jobs:
fqbn: ${{ matrix.board.fqbn }}
platforms: ${{ matrix.board.platforms }}
libraries: |
# Install the library from the local path.
- source-path: ./
# - name: Arduino_PF1550
- source-url: https://github.com/arduino-libraries/Arduino_PF1550.git
- name: Arduino_PF1550
- source-url: https://github.com/arduino-libraries/Arduino_LowPowerPortentaC33.git
sketch-paths: |
${{ env.UNIVERSAL_SKETCH_PATHS }}
Expand All @@ -79,29 +77,5 @@ jobs:
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
path: ${{ env.SKETCHES_REPORTS_PATH }}
name: ${{ env.SKETCHES_REPORTS_ARTIFACT_NAME }}

report-size-deltas:
needs: build
# Run even if some compilations failed.
if: always() && github.event_name == 'pull_request'
runs-on: ubuntu-latest
permissions:
pull-requests: write

steps:
- name: Download sketches reports artifact
id: download-artifact
continue-on-error: true # If compilation failed for all boards then there are no artifacts
uses: actions/download-artifact@v4
with:
name: ${{ env.SKETCHES_REPORTS_ARTIFACT_NAME }}
path: ${{ env.SKETCHES_REPORTS_PATH }}

- name: Comment size deltas report to PR
uses: arduino/report-size-deltas@v1
# If actions/download-artifact failed, there are no artifacts to report from.
if: steps.download-artifact.outcome == 'success'
with:
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}
83 changes: 0 additions & 83 deletions examples/DeepSleep_WakeFromRTC_H7/DeepSleep_WakeFromRTC_H7.ino

This file was deleted.

Loading
Loading