Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portenta Mid Carrier Proto shield, firmware updater fix #23

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

marqdevx
Copy link
Member

Modified the FirmwareUpdater sketch to not compile anything related to the Arduino_LED_Matrix library when the Arduino UNO R4 is NOT the target board.

The case scenario is when the Portenta Mid Carrier Proto shield is being used.

@per1234 per1234 added bug Something isn't working documentation Improvements or additions to documentation labels Feb 14, 2025
Copy link
Contributor

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove defined(ARDUINO_MINIMA) since the LED matrix doesn't make sense on that target too

@marqdevx marqdevx requested a review from facchinm February 17, 2025 13:38
@facchinm facchinm merged commit feef426 into arduino-libraries:main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants