Explicit use of includes from ArduinoCore-API#281
Open
TiboDevC wants to merge 1 commit into
Open
Conversation
Those files are located under the "api" directory of `ArduinoCore-API` repository https://github.com/arduino/ArduinoCore-API Those same files are also located in the ArduinoCore-samd repository https://github.com/arduino/ArduinoCore-samd and conflicting. So, to make it more explicit, specify the `api` directory.
|
|
|
Memory usage change @ eac3331
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those files:
IPAddress.hPrint.hClient.hServer.hUdp.hare located under the
apidirectory ofArduinoCore-APIrepository https://github.com/arduino/ArduinoCore-APIThose same files are also located in the
ArduinoCore-samdrepository https://github.com/arduino/ArduinoCore-samdand conflicting.
When compiling for SAMD21, files from
ArduinoCore-samdare used as theapidirectory is not specified while files from theArduinoCore-APIshould be used.The result is a conflict of declarations (
class UDPbeing declared twice for example) and compilation fails.So, this merge request explicit the
apidirectory to avoid confusion and useArduinoCore-API.