Align tensorArena in IMU_Classifier to 16 bytes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TensorFlowLite library checks that the supplied arena memory is aligned to 16 bytes, and crashes if it is not. This change ensures the memory is aligned as expected.
|
|
|
Hi @aentinger, both this PR and the fix suggested in #21 are mandatory to get the examples working properly in all the possibile scenarios. I'm asking the user of #21 to create a PR to submit his fix. Thanks! |
|
Hi @manchoz 👋 - sure - anything special you need me to do? (It appears you want me to merge this PR which I can, once the CLA is signed). |
|
Hi @Rainycat would you mind to sign the CLA? This is mandatory for approving the PR. Thanks! |
|
This fixes #21. |
aentinger
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TensorFlowLite library checks that the supplied arena memory
is aligned to 16 bytes, and crashes if it is not. This change
ensures the memory is aligned as expected.
There's a pull request already waiting, but it seems to be a more comprehensive (and more complicated!) fix. This might be a more simple way to get things working for now.