Skip to content

feat: progress for the remote sketch creation #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

feat: progress for the remote sketch creation #1673

merged 1 commit into from
Nov 17, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Nov 14, 2022 •
edited
Loading

Motivation

Show progress when creating the remote sketch.

Change description

Other information

1668.mp4

Closes #1668

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 14, 2022
AlbyIanna
AlbyIanna approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@kittaakos kittaakos merged commit 1a7784a into main Nov 17, 2022
@kittaakos kittaakos deleted the #1668 branch November 17, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@91volt 91volt 91volt approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate progress of the new remote sketch creation
3 participants
@kittaakos @AlbyIanna @91volt