Skip to content

fix: remote sketch creation if tree is not active #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: remote sketch creation if tree is not active #1717

merged 1 commit into from
Nov 29, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Nov 28, 2022

Motivation

The new remote sketch creation must work from File > New Remote Sketch or Ctrl/Cmd+Alt+N when a user is logged in, but the Remote Sketchbook is not the active tree inside the Sketchbook view.

Change description

New API to access all widgets besides the currently selected one.

Other information

Closes #1715

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 28, 2022
@kittaakos kittaakos changed the title fix: remote sketch creation if view is not active fix: remote sketch creation if tree is not active Nov 28, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1715

Thanks Akos!

Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@kittaakos kittaakos merged commit c0488d1 into main Nov 29, 2022
@kittaakos kittaakos deleted the #1715 branch November 29, 2022 10:19
@per1234 per1234 added the topic: cloud Related to Arduino Cloud and cloud sketches label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting "New Remote Sketch" from File menu has no effect if "Remote Sketchbook" widget is not open
3 participants