Skip to content

feat: configure sketchbook location without restart #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2022
Merged

feat: configure sketchbook location without restart #1774

merged 1 commit into from
Dec 21, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Dec 15, 2022 •
edited
Loading

Motivation

  • Handle invalid directories.user path in arduino-cli.yaml at app startup.
  • Change the sketchbook location from IDE2 without a restart.
  • Show the File > Sketchbook menu item even if no sketches are in the folder.
  • Show the Tools > Port menu item even if there are no available ports.

Preview:

1764_preview.mp4

Change description

  • IDE2 can start when directories.user is invalid or does not exist.
  • If directories.user is not a valid directory, IDE2 toasts an error message at startup.
  • Save As..., Open, Archive Sketch, and Add .ZIP Library... are fully functional when there is no valid directories.user value is set.
  • If directories.user does not exist, IDE2 tries to create the folder.
  • It's possible to change the directories.user location from the IDE2's Settings dialog.
  • When the user changes the directories.user, File > Sketchbook, File > Examples, and Sketch > Include Library` submenus update.
  • When the directories.user is invalid or empty, File > Sketchbook is visible but disabled.
  • Tools > Port is visible but disabled when no available ports are detected.

Other information

Closes #1764
Closes #796
Closes #569
Closes #655

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos force-pushed the #1764-signed branch 3 times, most recently from 3efc3fd to 2d8267d Compare December 15, 2022 16:11
@kittaakos kittaakos requested review from per1234 and AlbyIanna and removed request for per1234 December 19, 2022 08:48
@kittaakos kittaakos marked this pull request as ready for review December 19, 2022 08:48
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 19, 2022
per1234
per1234 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes:

Thanks Akos!

feat: configure sketchbook location without restart
6273734 
Closes #1764
Closes #796
Closes #569
Closes #655

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos merged commit 76f9f63 into main Dec 21, 2022
@kittaakos kittaakos deleted the #1764-signed branch December 21, 2022 14:44
@per1234 per1234 mentioned this pull request Dec 27, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
2 participants
@kittaakos @per1234