Skip to content

fix: added GH token for vscode-ripgrep download #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: added GH token for vscode-ripgrep download #1883

merged 1 commit into from
Feb 13, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

Fix internationalization check build failure due to HTTP 403 (rate-limiter) when downloading vscode-ripgrep

Change description

Added the GITHUB_TOKEN environment variable: https://github.com/microsoft/vscode-ripgrep#github-api-limit-note

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: added GH token for vscode-ripgrep download
ada3036 
Otherwise, yarn install hits an HTTP 403 due to the rate-limiter.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added the topic: infrastructure Related to project infrastructure label Feb 13, 2023
@kittaakos kittaakos requested a review from per1234 February 13, 2023 09:12
per1234
per1234 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Feb 13, 2023
@kittaakos kittaakos merged commit 25b545d into main Feb 13, 2023
@kittaakos kittaakos deleted the use-gh-token-for-i18n-task branch February 13, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @per1234