Skip to content

fix: can unset network#proxy in the CLI config #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: can unset network#proxy in the CLI config #2185

wants to merge 2 commits into from

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Aug 22, 2023

Motivation

Users can alter the Manual proxy configuration IDE2 settings to No proxy.

Change description

An empty object ({}) must be used to correctly unset the CLI config value to its default.

Other information

Closes #2184

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

An empty object (`{}`) must be used to correctly unset the CLI config
value to its default.

Closes #2184
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 22, 2023
@kittaakos kittaakos self-assigned this Aug 22, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I find that #2184 still occurs when using the build from this PR (67e0d93). I'm following the same procedure as described in #2184.

I see this printed in the logs after I perform step (9) of the demonstration:

2023-08-22T14:56:19.478Z config INFO Updating daemon with 'data': {
  "board_manager": {
    "additional_urls": []
  },
  "build_cache": {
    "compilations_before_purge": 10,
    "ttl": "720h0m0s"
  },
  "daemon": {
    "port": "50051"
  },
  "directories": {
    "data": "c:\\Users\\per\\AppData\\Local\\Arduino15",
    "user": "c:\\Users\\per\\Documents\\Arduino"
  },
  "library": {
    "enable_unsafe_install": false
  },
  "locale": "en",
  "logging": {
    "file": "",
    "format": "text",
    "level": "info"
  },
  "metrics": {
    "addr": ":9090",
    "enabled": true
  },
  "network": {},
  "output": {
    "no_color": false
  },
  "sketch": {
    "always_export_binaries": false
  },
  "updater": {
    "enable_notification": true
  }
}

@kittaakos

This comment was marked as duplicate.

@kittaakos
Copy link
Contributor Author

Blocked by arduino/arduino-cli#2275

@kittaakos kittaakos marked this pull request as draft August 23, 2023 09:48
@per1234 per1234 added the status: blocked Progress on this prevented by an external cause label Aug 24, 2023
@kittaakos kittaakos added the topic: CLI Related to Arduino CLI label Sep 12, 2023
@kittaakos
Copy link
Contributor Author

It will be part of #2334.

Closing as a duplicate

@kittaakos kittaakos closed this Jan 18, 2024
@kittaakos kittaakos added conclusion: duplicate Has already been submitted and removed status: blocked Progress on this prevented by an external cause labels Jan 18, 2024
@kittaakos kittaakos deleted the #2184 branch February 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy configuration can't be unset
2 participants