Skip to content

add missing translation in menu #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add missing translation in menu #2221

wants to merge 1 commit into from

Conversation

DanielFrantes
Copy link

@DanielFrantes DanielFrantes commented Sep 7, 2023

Motivation

Because I want to help. And this is perfect first issue. closes #2213

Change description

tanslate the opinion.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2023

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 self-assigned this Sep 7, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit a pull request @danik292.

This project uses a base locale of en. The base localization data is defined by the strings passed to nls.localize. This data is then uploaded to the "Arduino IDE 2.0" project on the Transifex localization platform, where it is localized to each of the other 17 supported locales.

So changing the base data string from the correct English to German is not the correct way to fix this problem and we will not be able to accept this pull request. I provide some information on the cause of the problem here: #2213 (comment)

If you are interested in contributing to the Arduino IDE translations, you can learn how from this guide:

https://github.com/arduino/arduino-ide/blob/main/docs/contributor-guide/translation.md#translator-guide

@per1234 per1234 closed this Sep 7, 2023
@per1234 per1234 added conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translation for "Save"
3 participants