Skip to content

chore(cli): update CLI to 0.35.0-rc.2 #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Oct 26, 2023

Motivation

Use the latest CLI (0.35.0-rc.2) in IDE2.

Change description

  • Update CLI to 0.35.0-rc.2.
  • Update Arduino LS to 0.7.5.
  • Adjust board discovery to new gRPC API. From now on, it's a client read stream, not a duplex.
  • Allow .cxx and .cc file extensions.
  • Handle the v prefix in the CLI's GitHub release name when generating JS/TS from proto.

Other information

Closes #2265

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server topic: CLI Related to Arduino CLI labels Oct 26, 2023
@kittaakos kittaakos self-assigned this Oct 26, 2023
@kittaakos
Copy link
Contributor Author

TODO: Go version must be updated to 1.21 in the workflow.

When building the CLI from sources:

go build
arduino/cores/status.go:21:2: package slices is not in GOROOT (/usr/local/Cellar/go/1.20.4/libexec/src/slices)
note: imported by a module that requires go 1.21

@alessio-perugini
Copy link

alessio-perugini commented Nov 6, 2023

After starting the IDE, after a few seconds, it goes to a blank screen and shows the following error:

Error sending from webFrameMain:  Error: Render frame was disposed before WebFrameMain could be accessed
    at WebFrameMain.send (node:electron/js2c/browser_init:2:94495)
    at WebContents.send (node:electron/js2c/browser_init:2:79721)
    at e.sendWindowEvent (/tmp/.mount_arduinsfQhdn/resources/app/lib/backend/electron-main.js:2:999627)
    at BrowserWindow.<anonymous> (/tmp/.mount_arduinsfQhdn/resources/app/lib/backend/electron-main.js:2:1005868)
    at BrowserWindow.emit (node:events:525:35)

Tested on ubuntu 23.10 and also on ubuntu 23.04 in a vanilla VM
With the 2.2.1 I have no issues.

Things I've tried:

  • Running the latest nightly same blank issue
  • Cleaning the cache and restarting the ide doesn't work
  • Run on a clean VM with ubuntu 23.04: doesn't work either

The problem seems to be related to the new electron update. Testing nightly build with electron Electron/25.5.0 works fine.

EDIT: Trying Electron/27.0.2 seems to work! (#2277)

kittaakos pushed a commit that referenced this pull request Nov 6, 2023
@kittaakos kittaakos changed the title chore(cli): update CLI to 0.35.0-rc.1 chore(cli): update CLI to 0.35.0-rc.2 Nov 10, 2023
Akos Kitta added 2 commits November 10, 2023 16:05
 - Adjust board discovery to new gRPC API. From now on, it's a client
 read stream, not a duplex.
 - Allow `.cxx` and `.cc` file extensions. (Closes #2265)

Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor Author

Duplicate of #2281

@kittaakos kittaakos marked this as a duplicate of #2281 Nov 13, 2023
@kittaakos kittaakos closed this Nov 13, 2023
@kittaakos kittaakos deleted the cli-0.35.0-rc.1 branch November 13, 2023 12:34
@kittaakos kittaakos added the conclusion: duplicate Has already been submitted label Nov 13, 2023
kittaakos pushed a commit that referenced this pull request Nov 15, 2023
kittaakos pushed a commit that referenced this pull request Nov 17, 2023
kittaakos pushed a commit that referenced this pull request Nov 17, 2023
kittaakos pushed a commit that referenced this pull request Dec 13, 2023
kittaakos pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: CLI Related to Arduino CLI topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure topic: language server Related to the Arduino Language Server type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow .cxx and .cc extensions
2 participants