build(deps): Bump actions/setup-go from 4 to 5 #2302
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
per1234
added
type: enhancement
There was a problem hiding this comment.
The Linux build of Arduino IDE is dynamically linked against the glibc shared library. This results in it having a dependency on the version of the library that happens to be present in the environment it is built in. The container the Linux build runs in is intentionally configured to have an older version of glibc (#2253). This provides compatibility with a reasonable range of older distro versions that might be present on the Linux machines of Arduino IDE users (newer versions of glibc are compatible with executables linked against an older version but the reverse is not true).
Unfortunately version 5.x of the actions/setup-go GitHub Actions action used by the build job has a dependency on a higher version of glibc than is provided by the Linux container. That dependency mismatch is the case of the error that occurs at the action's step in the job after the bump proposed by this PR:
https://github.com/arduino/arduino-ide/actions/runs/7133373110/job/19425968441#step:8:86
Run actions/setup-go@v5
/usr/bin/docker exec 12c414a867245060fb29c15f66d1ad8ab4c891ec82fb1179186d007776f616c8 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
This is the reason the workflow was intentionally configured to use actions/setup-go@v4 for the Linux build job (#2301 / e7754b7). So it is necessary to decline this bump.
Dependabot will remember this decision and only submit another PR for bumping actions/setup-go at such time the action has another major version bump (i.e., v5 -> v6). At that time, we should accept the bump in all workflow steps other than this specific step, which must remain at actions/setup-go@v4 unless we eventually abandon support for the older distro versions and update the container so that a newer version of glibc is available.
|
@dependabot ignore this major version |
|
OK, I won't notify you about version 5.x.x again, unless you re-open this PR. |
dependabot
bot
deleted the
dependabot/github_actions/actions/setup-go-5
branch
Bumps actions/setup-go from 4 to 5.
Release notes
Sourced from actions/setup-go's releases.
Commits
0c52d54Update dependencies for node20 (#445)bfd2fb3Merge pull request #421 from chenrui333/node20-runtime3d65fa5feat: bump to use actions/checkout@v48a505c9feat: bump to use node20 runtime883490dMerge pull request #417 from artemgavrilov/maind45ebbaRephrase sentence317c661Replacewildcardsterm withglobs.f90673aMerge pull request #1 from artemgavrilov/caching-docs-improvement8018234Improve documentation regarding dependencies cachind085b4fMerge pull request #411 from galargh/fix/windows-hostedtoolcacheDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)