Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: safer electron version parsing for electron-builder command #2673

Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix: safer electron version parsing for electron-builder command #2673

merged 1 commit into from
Apr 1, 2025

Conversation

giacomocusinato
Copy link
Collaborator

Motivation

Check if electron version parsing is correctly parsed by semver package. Also fix error warning for invalid type

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

csarnataro
csarnataro approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@csarnataro csarnataro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giacomocusinato giacomocusinato merged commit 4b0982c into arduino:main Apr 1, 2025
28 checks passed
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csarnataro csarnataro csarnataro approved these changes

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giacomocusinato @csarnataro @per1234