Added Preferences option for automatic sketch name sanitization#2896
Open
donatali wants to merge 2 commits into
Open
Added Preferences option for automatic sketch name sanitization#2896donatali wants to merge 2 commits into
donatali wants to merge 2 commits into
Conversation
Implemented existing toValidSketchName function to automatically sanitize invalid sketch names. Added checkbox in
Preferences to toggle automatic santization.
- True: All invalid characters are replaced with _. Pop up message notifies user.
- False: Previous behavior of reminding the user of correct naming format and prompting to rename sketch.
Resolves arduino#2866 (arduino#2866)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding back a convenient feature that the community seemed to like.
Change description
Implemented checkbox in Preferences to toggle automatic sketch name sanitization. Made use of toValidSketchName (already written) sanitize sketch names.
- True: All invalid characters are replaced with _. Pop up message notifies user.
- False: Reminds the user of correct naming format and prompts to rename sketch.
Resolves (#2866)