[WIP] Add build target for Apple Silicon #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Closing to reset and resbumit; some automated changes were helpfully committed by Github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change hopefully adds Apple Silicon build support as requested in #19.
x64runners is macOS 13, where the new runners are at least macOS 14.x64on any macOS runner (seepackage.json) has been removed. In theory, this means thatelectron-buildwill generate its artifacts based on the architecture of the runner.@ubidefeo I understand that priority is for bug fixes etc. This PR is being raised as a starting point only (hence WIP), any feedback would be appreciated.