nall: Resolve all file paths passed on command line #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like we should do the path resolution earlier in the chain; perhaps when command line arguments are first parsed since there may be other parts of the code that expect location to be absolute, |
jcm93
force-pushed
the
fix/relative-path-loading
branch
2 times, most recently
from
6897f25 to
8beb80e
Compare
jcm93
changed the title
|
Agreed; changed. Seems to work fine in my testing so far. |
jcm93
force-pushed
the
fix/relative-path-loading
branch
from
8beb80e to
a1c04fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a game from the command line with a relative path with a saves directory unspecified,
nall::Locationwould fail to return a valid directory for the load location, because it expects an absolute path.