fix: resolve HuggingFace Spaces runtime error during deployment#5851
Open
u-sheikh wants to merge 2 commits intoargilla-io:developfrom
Open
fix: resolve HuggingFace Spaces runtime error during deployment#5851u-sheikh wants to merge 2 commits intoargilla-io:developfrom
u-sheikh wants to merge 2 commits intoargilla-io:developfrom
Conversation
The issue was in the username retrieval logic in start.sh. When the HuggingFace API returns an error (e.g., user not found), jq would return the literal string "null" instead of triggering the fallback to SPACE_AUTHOR_NAME. Changes: - Use jq's '// empty' alternative operator to return empty string instead of "null" when the .user field is missing or null - Use bash parameter expansion to properly fallback to SPACE_AUTHOR_NAME - Add proper quoting around the curl URL This fixes the runtime error reported in issue argilla-io#5845.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was in the username retrieval logic in start.sh. When the HuggingFace API returns an error (e.g., user not found), jq would return the literal string "null" instead of triggering the fallback to SPACE_AUTHOR_NAME.
Changes:
This fixes the runtime error reported in issue #5845.
Description
Closes #<issue_number>
Type of change
How Has This Been Tested
Checklist