fix: reverse syncwave order (#12376) #13101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpaneas
changed the title
crenshaw-dev
changed the title
Signed-off-by: Panagiotis Georgiadis <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13101 +/- ##
==========================================
- Coverage 49.06% 49.01% -0.05%
==========================================
Files 246 246
Lines 42561 42586 +25
==========================================
- Hits 20881 20873 -8
- Misses 19565 19599 +34
+ Partials 2115 2114 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
This PR doesn't seem to address the issue properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to address the situation where when you try to delete a syncwaves-created deployment, it does so in reverse order. I tried to come up with a unit-test but it always passes (before and after this PR) so it was useless. I have not much experience with syncwaves nor their code, but from what I understand this feature never worked properly (I am talking about the deletion -- not the creation).
Checklist:
Fixes #12376