Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional resource health checks for pkg.crossplane.io (issue no. #21479) #21770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jan-mrm
Copy link

@jan-mrm jan-mrm commented Feb 4, 2025

Addition of resource health checks (with tests) for

pkg.crossplane.io/

  • Configuration
  • ConfigurationRevision
  • Function
  • FunctionRevision
  • ProviderRevision
    (Provider did already exist)

Closes #21479

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jan-mrm jan-mrm requested a review from a team as a code owner February 4, 2025 19:51
Copy link

bunnyshell bot commented Feb 4, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@7296201). Learn more about missing BASE report.
Report is 87 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21770   +/-   ##
=========================================
  Coverage          ?   55.63%           
=========================================
  Files             ?      339           
  Lines             ?    56836           
  Branches          ?        0           
=========================================
  Hits              ?    31618           
  Misses            ?    22564           
  Partials          ?     2654           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jan-mrm
Copy link
Author

jan-mrm commented Feb 4, 2025

Hey, since I did not add any checks for apiextensions.crossplane.io resources yet should I update the referenced issue and strikethrough or remove those? I'd probably look into them if I got some time but will do in another issue + pr.

@andrii-korotkov-verkada
Copy link
Contributor

Can you give a summary of why each health check is this way? I don't have context on specific resources and many people may not have it too, so adding that context would help reviews. Thanks.

@jan-mrm
Copy link
Author

jan-mrm commented Feb 17, 2025

I can, but I when looking into it I found this in the crossplane docs: crossplane-with-argo-cd so it might be better to just use that instead of adding those resource health checks. The provided lua code covers more resources and is tailored and maintained by the cossplane project. So that might be better. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement additional crossplane resource health checks
2 participants