Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appcontroller): Using impersonation when an application is deleted #21800

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anandf
Copy link
Contributor

@anandf anandf commented Feb 6, 2025

When implementing the app sync with impersonation feature, application controller impersonates only for a sync operation. This PR is enhancing that feature for the application deletion as well. When admin users want to avoid accidental deletion of resources, they can control it by removing the delete access to the impersonated service account.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@anandf anandf requested a review from a team as a code owner February 6, 2025 04:31
Copy link

bunnyshell bot commented Feb 6, 2025

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-5pvn3m.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-5pvn3m.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.61%. Comparing base (4a1d0f3) to head (8afa66e).

Files with missing lines Patch % Lines
controller/appcontroller.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21800      +/-   ##
==========================================
- Coverage   55.63%   55.61%   -0.02%     
==========================================
  Files         339      339              
  Lines       56813    56829      +16     
==========================================
- Hits        31608    31606       -2     
- Misses      22553    22571      +18     
  Partials     2652     2652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anandf anandf force-pushed the app_delete_with_impersonation branch from 52a1014 to 8afa66e Compare February 7, 2025 01:01
@anandf anandf marked this pull request as draft February 7, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant