Skip to content

chore(ui): rename "NAME PATTERN" to "NAME CONTAINS" in workflow template filters#16077

Merged
Joibel merged 2 commits into
argoproj:mainfrom
nakatani-yo:chore/ui-rename-name-pattern-to-name-contains
Jun 10, 2026
Merged

chore(ui): rename "NAME PATTERN" to "NAME CONTAINS" in workflow template filters#16077
Joibel merged 2 commits into
argoproj:mainfrom
nakatani-yo:chore/ui-rename-name-pattern-to-name-contains

Conversation

@nakatani-yo

@nakatani-yo nakatani-yo commented May 11, 2026

Copy link
Copy Markdown
Contributor

Motivation

The filter label "NAME PATTERN" on the Workflow Templates page is misleading. As shown in the ListWorkflowTemplates function in server/workflowtemplate/workflow_template_server.go, the server-side name filtering uses strings.Contains for simple substring matching, not regex or glob pattern matching:

// Enables name-based searching.
// Do name pattern filtering if NamePattern request exist.
var items []v1alpha1.WorkflowTemplate
if req.NamePattern != "" {
    for _, item := range wfList.Items {
        if strings.Contains(item.Name, req.NamePattern) {
            items = append(items, item)
        }
    }
    cursorPaginationByResourceVersion(items, resourceVersion, limit, wfList)
}

The UI label should accurately reflect this actual substring-match behavior.

image

Modifications

Renamed the filter label from "Name Pattern" to "Name Contains" in ui/src/workflow-templates/workflow-template-filters.tsx to align with the Workflow list page (ui/src/workflows/components/workflow-filters/workflow-filters.tsx), which already uses "Name Contains" for the same type of filter, and to accurately describe the substring-match behavior.

image

Verification

Verified in the browser that the filter label displays as "NAME CONTAINS" and the filtering behavior remains unchanged (substring match).

Documentation

No documentation changes needed — this is a UI label correction only.

AI

Codex, Gemini

…ate filters

Signed-off-by: nakatani-yo <yoshihito.nakatani@craftsman-software.com>
@nakatani-yo nakatani-yo changed the title chore(ui): rename "NAME PATTERN" to "NAME CONTAINS" in workflow templ… chore(ui): rename "NAME PATTERN" to "NAME CONTAINS" in workflow template filters May 11, 2026
@nakatani-yo nakatani-yo marked this pull request as ready for review May 12, 2026 23:58
@Joibel Joibel merged commit 751700d into argoproj:main Jun 10, 2026
20 checks passed
@nakatani-yo

Copy link
Copy Markdown
Contributor Author

@Joibel
Thank you for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants