chore(ui): rename "NAME PATTERN" to "NAME CONTAINS" in workflow template filters#16077
Merged
Joibel merged 2 commits intoJun 10, 2026
Merged
Conversation
…ate filters Signed-off-by: nakatani-yo <yoshihito.nakatani@craftsman-software.com>
Joibel
approved these changes
Jun 10, 2026
Contributor
Author
|
@Joibel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The filter label "NAME PATTERN" on the Workflow Templates page is misleading. As shown in the
ListWorkflowTemplatesfunction inserver/workflowtemplate/workflow_template_server.go, the server-side name filtering usesstrings.Containsfor simple substring matching, not regex or glob pattern matching:The UI label should accurately reflect this actual substring-match behavior.
Modifications
Renamed the filter label from "Name Pattern" to "Name Contains" in
ui/src/workflow-templates/workflow-template-filters.tsxto align with the Workflow list page (ui/src/workflows/components/workflow-filters/workflow-filters.tsx), which already uses "Name Contains" for the same type of filter, and to accurately describe the substring-match behavior.Verification
Verified in the browser that the filter label displays as "NAME CONTAINS" and the filtering behavior remains unchanged (substring match).
Documentation
No documentation changes needed — this is a UI label correction only.
AI
Codex, Gemini