-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync-options annotation with Force=true (#414) #560
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 54.71% 54.66% -0.05%
==========================================
Files 41 41
Lines 4834 4648 -186
==========================================
- Hits 2645 2541 -104
+ Misses 1977 1910 -67
+ Partials 212 197 -15 ☔ View full report in Codecov by Sentry. |
c39a776
to
bba3871
Compare
Kudos, SonarCloud Quality Gate passed!
|
Any chance this can get merged soon? |
Also interested in seeing this merged |
It's now been almost two years since we're waiting for that fix ( #414 ) |
@kkk777-7 , i am really sorry for long review on it, could you please solve conflicts ? |
Signed-off-by: kkk777-7 <[email protected]>
bba3871
to
a463a21
Compare
|
@pasha-codefresh , thank you reply! I resolved conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! Please let me know if any help needed with update gitops-engine inside argocd
This PR implements #414, argoproj/argo-cd#5882
Changes:
argocd.argoproj.io/sync-options: Force=true
Related: #526