chore: enable use-any from revive #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
golangci-lint/revive
branch
from
d615fe4 to
159d997
Compare
|
/cc @crenshaw-dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 54.26% 54.46% +0.20%
==========================================
Files 64 64
Lines 6164 6268 +104
==========================================
+ Hits 3345 3414 +69
- Misses 2549 2581 +32
- Partials 270 273 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
golangci-lint/revive
branch
from
2b79b20 to
69c3e47
Compare
|
crenshaw-dev
approved these changes
Feb 6, 2025
andrii-korotkov-verkada
pushed a commit
to andrii-korotkov-verkada/gitops-engine
that referenced
this pull request
Feb 7, 2025
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]>
leoluz
pushed a commit
that referenced
this pull request
Feb 7, 2025
…662) * fix: New kube applier for server side diff dry run with refactoring Part of a fix for: argoproj/argo-cd#21488 Separate logic to handle server side diff dry run applies. Signed-off-by: Andrii Korotkov <[email protected]> * Break backwards compatibility for a better code Signed-off-by: Andrii Korotkov <[email protected]> * Don't put applier constructor in the interface Signed-off-by: Andrii Korotkov <[email protected]> * Address comments Signed-off-by: Andrii Korotkov <[email protected]> * Address more comments Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable testifylint linter (#657) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable gofumpt, gosimple and whitespace linters (#666) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable use-any from revive (#667) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: bump golangci-lint to v1.63.4 and list argo-cd linters (#670) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable unused-parameter and var-declaration from revive (#668) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: remove actions/cache duplicated behavior with actions/setup-go (#658) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * Add Leo's code Signed-off-by: Andrii Korotkov <[email protected]> * Make linter happy Signed-off-by: Andrii Korotkov <[email protected]> --------- Signed-off-by: Andrii Korotkov <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]>
Aaron-9900
pushed a commit
to Aaron-9900/gitops-engine
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Aaron Hoffman <[email protected]>
Aaron-9900
pushed a commit
to Aaron-9900/gitops-engine
that referenced
this pull request
Feb 12, 2025
…rgoproj#662) * fix: New kube applier for server side diff dry run with refactoring Part of a fix for: argoproj/argo-cd#21488 Separate logic to handle server side diff dry run applies. Signed-off-by: Andrii Korotkov <[email protected]> * Break backwards compatibility for a better code Signed-off-by: Andrii Korotkov <[email protected]> * Don't put applier constructor in the interface Signed-off-by: Andrii Korotkov <[email protected]> * Address comments Signed-off-by: Andrii Korotkov <[email protected]> * Address more comments Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable testifylint linter (argoproj#657) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable gofumpt, gosimple and whitespace linters (argoproj#666) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable use-any from revive (argoproj#667) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: bump golangci-lint to v1.63.4 and list argo-cd linters (argoproj#670) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: enable unused-parameter and var-declaration from revive (argoproj#668) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * chore: remove actions/cache duplicated behavior with actions/setup-go (argoproj#658) Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Andrii Korotkov <[email protected]> * Add Leo's code Signed-off-by: Andrii Korotkov <[email protected]> * Make linter happy Signed-off-by: Andrii Korotkov <[email protected]> --------- Signed-off-by: Andrii Korotkov <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]> Signed-off-by: Aaron Hoffman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.