New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Add timestamps option to asynceapi client and update typing #1035

Open

carl-baillargeon wants to merge 4 commits into aristanetworks:main from carl-baillargeon:feat/asynceapi_typing_and_timestamps

+271 −58

Contributor

carl-baillargeon commented Feb 11, 2025 •

edited

Loading

Description

Add timestamps option to asynceapi for eAPI requests. Also updated typing for asynceapi.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)

carl-baillargeon added 4 commits

November 11, 2024 16:38


          Update asynceapi typing

91eb580


          Update with main

bf797f6


          Add timestamps

8b23a74


          Merge branch 'main' into feat/asynceapi_typing_and_timestamps

8e560e6

github-actions bot assigned carl-baillargeon

sonarqubecloud bot commented Feb 11, 2025

Quality Gate failed

Failed conditions
75.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet