-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(anta.tests): Nicer result failure messages hardware test module #1044
base: main
Are you sure you want to change the base?
refactor(anta.tests): Nicer result failure messages hardware test module #1044
Conversation
CodSpeed Performance ReportMerging #1044 will not alter performanceComparing Summary
|
"{'DomTemperatureSensor54': " | ||
"{'hwStatus': 'ko', 'alertCount': 0}}", | ||
], | ||
"messages": ["Sensor: DomTemperatureSensor54 - Invalid Hardware State - Expected: ok Actual: ko"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardware State, does that mean temperature range like it was previously mentionned? I feel like it is not the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @carl-baillargeon ,
Here , We are validating the same parameter as earlier validation {'hwStatus': 'ko', 'alertCount': 0}}
I have divided this check into two separate messages.,
1. Check for 'hwStatus': 'ok' am updating it as
Sensor: DomTemperatureSensor54 - Invalid Hardware State - Expected: ok Actual: ko
1. Check for 'alertCount': 0' am updating it as
Sensor: DomTemperatureSensor54 - Non-zero alert counter - Actual: 1
Can you please guide me here? Do we need to update the message or validation?
|
Nicer result failure messages for following test module.
Note: Test with the Unit tests only, not able to test on ATD lab.
Fixes #587
Checklist:
pre-commit run
)tox -e testenv
)