Feat(eos_cli_config_gen): Add interface TE twamp-light with fallback …

…knobs (#4935) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mahesh Kumar <[email protected]> Co-authored-by: Guillaume Mulocher <[email protected]> Co-authored-by: Claus Holbech <[email protected]>
aristanetworks · Feb 6, 2025 · 66d965f · 66d965f
1 parent c15b52c
commit 66d965f
Show file tree

Hide file tree

Showing 14 changed files with 346 additions and 27 deletions.
diff --git a/...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md b/...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
@@ -3934,6 +3934,7 @@ interface Dps1
 | Interface | Enabled | Administrative Groups | Metric | Max Reservable Bandwidth | Min-delay | SRLG |
 | --------- | ------- | --------------------- | ------ | ------------------------ | --------- | ---- |
 | Ethernet81/3 | True | 3,15-29,testgrp | 4 | 10 percent | 5 microseconds | TEST-SRLG |
+| Ethernet81/4 | True | 4,7-100,testgrp | 2 | 100 mbps | twamp-light, fallback 2 milliseconds | 16 |
 
 #### Ethernet Interfaces Device Configuration
 
@@ -4940,11 +4941,12 @@ interface Ethernet81/4
    no shutdown
    no switchport
    ip address 100.64.127.0/31
+   traffic-engineering
    traffic-engineering bandwidth 100 mbps
    traffic-engineering administrative-group 4,7-100,testgrp
    traffic-engineering srlg 16
    traffic-engineering metric 2
-   traffic-engineering min-delay static 2 milliseconds
+   traffic-engineering min-delay dynamic twamp-light fallback 2 milliseconds
 !
 interface Ethernet81/10
    description isis_port_channel_member
@@ -5193,7 +5195,7 @@ interface Ethernet84
 
 | Interface | Enabled | Administrative Groups | Metric | Max Reservable Bandwidth | Min-delay | SRLG |
 | --------- | ------- | --------------------- | ------ | ------------------------ | --------- | ---- |
-| Port-Channel136 | True | 7 | - | - | - | - |
+| Port-Channel136 | True | 7 | - | - | twamp-light, fallback 123 microseconds | - |
 
 #### Port-Channel Interfaces Device Configuration
 
@@ -5814,6 +5816,7 @@ interface Port-Channel136
    ip address 100.64.127.2/31
    traffic-engineering
    traffic-engineering administrative-group 7
+   traffic-engineering min-delay dynamic twamp-light fallback 123 microseconds
 !
 interface Port-Channel137
    description Traffic Engineering Interface

diff --git a/ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg b/ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
@@ -2286,6 +2286,7 @@ interface Port-Channel136
    ip address 100.64.127.2/31
    traffic-engineering
    traffic-engineering administrative-group 7
+   traffic-engineering min-delay dynamic twamp-light fallback 123 microseconds
 !
 interface Port-Channel137
    description Traffic Engineering Interface
@@ -3308,11 +3309,12 @@ interface Ethernet81/4
    no shutdown
    no switchport
    ip address 100.64.127.0/31
+   traffic-engineering
    traffic-engineering bandwidth 100 mbps
    traffic-engineering administrative-group 4,7-100,testgrp
    traffic-engineering srlg 16
    traffic-engineering metric 2
-   traffic-engineering min-delay static 2 milliseconds
+   traffic-engineering min-delay dynamic twamp-light fallback 2 milliseconds
 !
 interface Ethernet81/10
    description isis_port_channel_member

diff --git a/.../arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ethernet-interfaces.yml b/.../arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ethernet-interfaces.yml
@@ -1897,7 +1897,7 @@ ethernet_interfaces:
       enabled: false
     ip_address: 100.64.127.0/31
     traffic_engineering:
-      enabled: false
+      enabled: true
       administrative_groups:
         - 4
         - 7-100
@@ -1907,9 +1907,10 @@ ethernet_interfaces:
       bandwidth:
         number: 100
         unit: mbps
-      min_delay_static:
-        number: 2
-        unit: milliseconds
+      min_delay_dynamic:
+        twamp_light_fallback:
+          number: 2
+          unit: milliseconds
 
   - name: Ethernet82
     description: Switchport_tap_tool

diff --git a/...sta/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/port-channel-interfaces.yml b/...sta/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/port-channel-interfaces.yml
@@ -1070,6 +1070,10 @@ port_channel_interfaces:
       enabled: true
       administrative_groups:
         - 7
+      min_delay_dynamic:
+        twamp_light_fallback:
+          number: 123
+          unit: microseconds
 
   - name: Port-Channel137
     description: Traffic Engineering Interface

diff --git a/...lections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md b/...lections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
diff --git a/...ions/arista/avd/roles/eos_cli_config_gen/docs/tables/port-channel-interfaces.md b/...ions/arista/avd/roles/eos_cli_config_gen/docs/tables/port-channel-interfaces.md
diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2
@@ -819,6 +819,8 @@
 {%             endif %}
 {%             if te_interface.traffic_engineering.min_delay_static is arista.avd.defined %}
 {%                 set te_min_del = te_interface.traffic_engineering.min_delay_static.number ~ " " ~ te_interface.traffic_engineering.min_delay_static.unit %}
+{%             elif te_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback is arista.avd.defined %}
+{%                 set te_min_del = "twamp-light, fallback " ~ te_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.number ~ " " ~ te_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.unit %}
 {%             else %}
 {%                 set te_min_del = "-" %}
 {%             endif %}

diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
@@ -435,6 +435,8 @@
 {%             endif %}
 {%             if po_te_interface.traffic_engineering.min_delay_static is arista.avd.defined %}
 {%                 set te_min_del = po_te_interface.traffic_engineering.min_delay_static.number ~ " " ~ po_te_interface.traffic_engineering.min_delay_static.unit %}
+{%             elif po_te_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback is arista.avd.defined %}
+{%                 set te_min_del = "twamp-light, fallback " ~ po_te_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.number ~ " " ~ po_te_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.unit %}
 {%             else %}
 {%                 set te_min_del = "-" %}
 {%             endif %}

diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
@@ -1143,6 +1143,8 @@ interface {{ ethernet_interface.name }}
 {%     endif %}
 {%     if ethernet_interface.traffic_engineering.min_delay_static is arista.avd.defined %}
    traffic-engineering min-delay static {{ ethernet_interface.traffic_engineering.min_delay_static.number }} {{ ethernet_interface.traffic_engineering.min_delay_static.unit }}
+{%     elif ethernet_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback is arista.avd.defined %}
+   traffic-engineering min-delay dynamic twamp-light fallback {{ ethernet_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.number }} {{ ethernet_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.unit }}
 {%     endif %}
 {%     for link_tracking_group in ethernet_interface.link_tracking_groups | arista.avd.natural_sort %}
 {%         if link_tracking_group.name is arista.avd.defined and link_tracking_group.direction is arista.avd.defined %}

diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/port-channel-interfaces.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/port-channel-interfaces.j2
@@ -954,6 +954,8 @@ interface {{ port_channel_interface.name }}
 {%     endif %}
 {%     if port_channel_interface.traffic_engineering.min_delay_static is arista.avd.defined %}
    traffic-engineering min-delay static {{ port_channel_interface.traffic_engineering.min_delay_static.number }} {{ port_channel_interface.traffic_engineering.min_delay_static.unit }}
+{%     elif port_channel_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback is arista.avd.defined %}
+   traffic-engineering min-delay dynamic twamp-light fallback {{ port_channel_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.number }} {{ port_channel_interface.traffic_engineering.min_delay_dynamic.twamp_light_fallback.unit }}
 {%     endif %}
 {%     for link_tracking_group in port_channel_interface.link_tracking_groups | arista.avd.natural_sort('name') %}
 {%         if link_tracking_group.name is arista.avd.defined and link_tracking_group.direction is arista.avd.defined %}