Refactor(eos_designs): Refactor eos_designs structured_config code for static_routes #4943
+50
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4943
# Activate the virtual environment
source test-avd-pr-4943/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@static_route#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,static_route --force
# Optional: Install AVD examples
cd test-avd-pr-4943
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
|
On Hold(requires the support of multiple primary keys) |
MaheshGSLAB
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
state: CI Updated
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
MaheshGSLAB
changed the title
Vibhu-gslab
requested changes
Feb 10, 2025
Comment on lines
66
to
69
| static_route = EosCliConfigGen.StaticRoutesItem( | ||
| destination_address_prefix="0.0.0.0/0", gateway=self.shared_utils.inband_mgmt_gateway, vrf=self.shared_utils.inband_mgmt_vrf | ||
| ) | ||
| self.structured_config.static_routes.append(static_route) |
There was a problem hiding this comment.
Suggested change
| static_route = EosCliConfigGen.StaticRoutesItem( | |
| destination_address_prefix="0.0.0.0/0", gateway=self.shared_utils.inband_mgmt_gateway, vrf=self.shared_utils.inband_mgmt_vrf | |
| ) | |
| self.structured_config.static_routes.append(static_route) | |
| self.structured_config.static_routes.append_new(destination_address_prefix="0.0.0.0/0", gateway=self.shared_utils.inband_mgmt_gateway, vrf=self.shared_utils.inband_mgmt_vrf) |
There was a problem hiding this comment.
We can use similar stuff for base.__init__.py as well, please check in other places too.
Comment on lines
142
to
145
| static_route = EosCliConfigGen.StaticRoutesItem( | ||
| vrf=self.inputs.mgmt_interface_vrf, destination_address_prefix=mgmt_destination_network, gateway=self.shared_utils.mgmt_gateway | ||
| ) | ||
| self.structured_config.static_routes.append(static_route) |
There was a problem hiding this comment.
Suggested change
| static_route = EosCliConfigGen.StaticRoutesItem( | |
| vrf=self.inputs.mgmt_interface_vrf, destination_address_prefix=mgmt_destination_network, gateway=self.shared_utils.mgmt_gateway | |
| ) | |
| self.structured_config.static_routes.append(static_route) | |
| self.structured_config.static_routes.append_new(vrf=self.inputs.mgmt_interface_vrf, destination_address_prefix=mgmt_destination_network, gateway=self.shared_utils.mgmt_gateway ) |
There was a problem hiding this comment.
Same in else part.
added 2 commits
February 11, 2025 13:53
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor(eos_designs): Refactor eos_designs structured_config code for static_routes
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Refactor(eos_designs): Refactor eos_designs structured_config code for static_routes
How to test
Run molecule
Checklist
User Checklist
Repository Checklist