Refactor(eos_designs): Refactor structured_config code for underlay/as.py
#4978
+11
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4978
# Activate the virtual environment
source test-avd-pr-4978/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/underlay/as-path#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/underlay/as-path --force
# Optional: Install AVD examples
cd test-avd-pr-4978
ansible-playbook arista.avd.install_examples |
laxmikantchintakindi
force-pushed
the
refactor/underlay/as-path
branch
2 times, most recently
from
2bb5a0c to
f6772a0
Compare
MaheshGSLAB
reviewed
Feb 5, 2025
Comment on lines
29
to
35
| access_lists = EosCliConfigGen.AsPath.AccessLists() | ||
| entries = EosCliConfigGen.AsPath.AccessListsItem.Entries() | ||
| entries.append_new(type="permit", match=self.shared_utils.bgp_as) | ||
| access_lists.append_new(name="ASPATH-WAN", entries=entries) | ||
|
|
||
| if access_lists: | ||
| self.structured_config.as_path._update(access_lists=access_lists) |
There was a problem hiding this comment.
Suggested change
| access_lists = EosCliConfigGen.AsPath.AccessLists() | |
| entries = EosCliConfigGen.AsPath.AccessListsItem.Entries() | |
| entries.append_new(type="permit", match=self.shared_utils.bgp_as) | |
| access_lists.append_new(name="ASPATH-WAN", entries=entries) | |
| if access_lists: | |
| self.structured_config.as_path._update(access_lists=access_lists) | |
| entries = EosCliConfigGen.AsPath.AccessListsItem.Entries() | |
| entries.append_new(type="permit", match=self.shared_utils.bgp_as) | |
| access_lists = EosCliConfigGen.AsPath.AccessListsItem(name="ASPATH-WAN", entries=entries) | |
| self.structured_config.as_path.access_lists.append(access_lists) |
laxmikantchintakindi
force-pushed
the
refactor/underlay/as-path
branch
from
6573094 to
b424f42
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor structured_config code for underlay/as.py
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Refactor structured_config code for underlay/as.py
How to test
Checklist
User Checklist
Repository Checklist