Allow skipping DataFrameClient import #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing the DataFrameClient can take quite a while, especially when the source files aren't yet loaded into the page cache. This patch adds an environment variable, INFLUXDB_NO_DATAFRAME_CLIENT, to allow users of this package to skip this import in cases where they don't need it.
Importing the DataFrameClient can take quite a while, especially when the source files aren't yet loaded into the page cache. This patch adds an environment variable, INFLUXDB_NO_DATAFRAME_CLIENT, to allow users of this package to skip this import in cases where they don't need it.
Importing the DataFrameClient can take quite a while, especially when the source files aren't yet loaded into the page cache. This patch adds an environment variable, INFLUXDB_NO_DATAFRAME_CLIENT, to allow users of this package to skip this import in cases where they don't need it.
|
code LGTM, Did you run all the unit tests? |
manojm321
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing the DataFrameClient can take quite a while,
especially when the source files aren't yet loaded into
the page cache.
This patch adds an environment variable, INFLUXDB_NO_DATAFRAME_CLIENT,
to allow users of this package to skip this import in cases where
they don't need it.
This pull request is a cherry pick of all the commits from
influxdata#850