Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update [SETTING] info #538

Merged
merged 4 commits into from
Nov 18, 2018
Merged

update [SETTING] info #538

merged 4 commits into from
Nov 18, 2018

Conversation

Thorin-Oakenpants
Copy link
Contributor

No description provided.

@earthlng
Copy link
Contributor

earthlng commented Nov 18, 2018

  • 0303: setting still exists if the maintenance service is installed
  • 0351: can we remove the SETTING here because 0351 has 4 prefs and the setting only toggles one of them? We can also move browser.crashReports.unsubmittedCheck.autoSubmit to 9999
  • 0422: Privacy & Security>Content Blocking>All Detected Trackers>Change block list
  • 0517: the setting can still exist but it's tied to the autofill system addon:

1
the checkbox currently only toggles extensions.formautofill.addresses.enabled but that may change (or maybe they'll add a new setting for "autofill creditcards")

  • 1401: Fonts & Colors
  • 2701: Privacy & Security>Privacy & Security>Cookies and Site Data>Accept/Block cookies and sita data (+ remove double Privacy & Security !)

@Thorin-Oakenpants
Copy link
Contributor Author

Thorin-Oakenpants commented Nov 18, 2018

if the maintenance service is installed

Ahhh. That caught me out. Because there are zillas for removing it completely

remove double Privacy & Security, Fonts & Colors

godamn it - its all good in my local copy. In future I think I'll just cut n paste my entire master local copy

the setting can still exist but it's tied to the autofill system addon

I checked it in FF64 nilla profile, with the xpi present

@Thorin-Oakenpants
Copy link
Contributor Author

browser.crashReports.unsubmittedCheck.autoSubmit => deprecated, will do separately (added it as an item in #533)

0517 - I put it back, wonder why it didn't show in 64 nilla

2701: Privacy & Security>Cookies and Site Data>Accept/Block cookies and site data

Why? It's exactly what I have it as, which is the combo box for "Type blocked"

@earthlng
Copy link
Contributor

Why? It's exactly what I have it as, which is the combo box for "Type blocked"

because the values are 0-4 and 0 is "Accept cookies and site data" which is not in "Type blocked".
But it doesn't really matter because the Content Blocking UI will be totally different again in FF65

@Thorin-Oakenpants
Copy link
Contributor Author

will be changed again in 65. Figures! Anyway, lets not split hairs - I know some prefs are controlled/set by others, but if we went with yours, then it wouldn't match any UI setting. Will fire this thru then.

@Thorin-Oakenpants Thorin-Oakenpants merged commit 13550d1 into master Nov 18, 2018
@Thorin-Oakenpants Thorin-Oakenpants deleted the Thorin-Oakenpants-patch-1 branch November 18, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants