Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Eq[Signal] #159

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Better Eq[Signal] #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aff2643
Restore all the `Monad` law tests
armanbilge Jan 23, 2023
70be22b
Write a better `Eq[Signal]`
armanbilge Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 11 additions & 20 deletions frp/src/test/scala/calico/frp/SignalSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,28 +79,19 @@ class SignalSuite extends DisciplineSuite, TestInstances:
)

given [A: Eq](using Eq[IO[List[(A, FiniteDuration)]]]): Eq[Signal[IO, A]] = Eq.by { sig =>
IO.ref(List.empty[(A, FiniteDuration)]).flatMap { ref =>
TestControl.executeEmbed(
sig
.discrete
.evalMap(IO.realTime.tupleLeft(_))
.evalMap(x => ref.update(x :: _))
.compile
.drain
.timeoutTo(Long.MaxValue.nanos, IO.unit),
seed = Some(testControlSeed)
) *> ref.get.map(_.distinctBy(_._2))
}
TestControl.executeEmbed(
sig
.discrete
.evalMap(IO.realTime.tupleLeft(_))
.interruptAfter(Long.MaxValue.nanos)
.compile
.to(List)
.map(_.reverse.distinctBy(_._2)), // reverse so latest wins in `distinctBy`
seed = Some(testControlSeed)
)
}

given Ticker = Ticker()

// it is stack-safe, but expensive to test
MonadTests[Signal[IO, _]].stackUnsafeMonad[Int, Int, Int].all.properties.foreach {
case (id, prop) =>
// TODO investigate failures #101
if !Set(
"monad (stack-unsafe).flatMap associativity",
"monad (stack-unsafe).semigroupal associativity").contains(id)
then property(id)(prop)
}
checkAll("Signal", MonadTests[Signal[IO, _]].stackUnsafeMonad[Int, Int, Int])