Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GitHub workflow for CI checks #1341

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Improve GitHub workflow for CI checks #1341

merged 1 commit into from
Jan 9, 2025

Conversation

fabiobrz
Copy link
Collaborator

@fabiobrz fabiobrz commented Jan 8, 2025 •
edited
Loading

Short description of what this resolves:

Improving the GitHub workflow for CI checks by separating jobs Docker, Kubernetes and OpenShift integration tests

Changes proposed in this pull request:

  • circleci workflow has been removed
  • GitHub workflow has been improved

Fixes #1343

@fabiobrz fabiobrz force-pushed the improve-github-workflow branch 2 times, most recently from 895b636 to b8fb47a Compare January 8, 2025 21:53
@fabiobrz fabiobrz requested a review from gaol January 8, 2025 22:07
@fabiobrz fabiobrz force-pushed the improve-github-workflow branch from b8fb47a to ae6affe Compare January 8, 2025 22:15
gaol
gaol approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@gaol gaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, having env setup in separate jobs is a better choice.

thanks @fabiobrz :)

@gaol
Copy link
Collaborator

gaol commented Jan 9, 2025 •
edited
Loading

@fabiobrz I cannot merge this pr because of 3 required status checks are expected, although they are removed by this pr.

@fabiobrz
Copy link
Collaborator Author

fabiobrz commented Jan 9, 2025

@fabiobrz I cannot merge this pr because of 3 required status checks are expected, although they are removed by this pr.

Thanks @gaol - should be fixed now. Feel free to ping me if that is not the case.

@fabiobrz fabiobrz force-pushed the improve-github-workflow branch from 2f93ed6 to 4bdcd25 Compare January 9, 2025 06:46
@fabiobrz
Copy link
Collaborator Author

fabiobrz commented Jan 9, 2025

BTW @gaol - I noticed you backported main into this feature branch, but that is not the way to update it with atest commits.
I have now rebased on main, and force pushed again, so that this branch is now aligned with the main branch history.

@gaol
Copy link
Collaborator

gaol commented Jan 9, 2025

@fabiobrz , cool, thank you. 👍

@gaol gaol merged commit 9baa2b6 into arquillian:main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaol gaol gaol approved these changes

Assignees

@gaol gaol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the GitHub workflow for CI checks
2 participants
@fabiobrz @gaol