Add European Excise Number #424
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedk
force-pushed
the
eu-excise-number
branch
from
21f80b9 to
7618f9b
Compare
|
For now the check_seed tests fails because the EU service does not respect its WSDL. |
cedk
force-pushed
the
eu-excise-number
branch
2 times, most recently
from
a870db1 to
32d0abf
Compare
cedk
force-pushed
the
eu-excise-number
branch
from
32d0abf to
4d832c2
Compare
| """Excise Number | ||
|
|
||
| The Excise Number is the identification number issued by the competent | ||
| authority in respect of the person or premises. |
There was a problem hiding this comment.
Can you add a bit more detail on what this number is and what it's used for?
| # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA | ||
| # 02110-1301 USA | ||
|
|
||
| """n° d'accise. |
There was a problem hiding this comment.
Can you improve this docstring a bit? For example: "n° d'accise (French number for ...)".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.