Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kurucz imported A values (100x too high from missing [Angstrom/nm]^2) #14

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

lukeshingles
Copy link
Member

Bug found by @fmcneill49 resulting in A values for imported Kurucz data (e.g. Sr, Y, Zr in Shingles et al. 2023) that were too high by 100x. So far this appears to not alter the conclusion of Shingles+23:

  • the light curve is similar within 25%
  • a similar spectral sequence is still seen, but evolving at a (~30%) slower rate. However, it was already the case that the rate of time evolution already did not AT2017gfo.
  • smaller changes in the spectra features look like they will improve the match to AT2017gfo. In Shingles+23, the spectra were heavily smoothed, which obscured differences at this level of significance.

Fixed simulations for (unpublished) higher mass models are in-progress, but will likely result is fairly large differences. This could help to fix the excess opacity at early times, and lack of blue flux in the spectra.

@lukeshingles lukeshingles enabled auto-merge (squash) February 10, 2025 13:29
@lukeshingles lukeshingles merged commit 600e6b3 into main Feb 10, 2025
6 checks passed
@lukeshingles lukeshingles deleted the fixkurucz_avalues branch February 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant