Pass threshold instead of level energy to photoionisation formula fits #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeshingles
force-pushed
the
cmfgenphotoionisationthresholdbug
branch
from
6f25018 to
5e9a4e4
Compare
lukeshingles
force-pushed
the
cmfgenphotoionisationthresholdbug
branch
from
5e9a4e4 to
24d948c
Compare
|
One zone test with Fe, Co (QUB data input unaffected by this change), and Ni. |
|
Actually the lambda_angstrom does contain the threshold wavelength, so there was not a real bug there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the threshold energy to CMFGEN formula fits, instead of incorrectly passing the level energy. EDIT: Actually the lambda_angstrom does contain the threshold wavelength, so there was not a real bug there.
For tables of cross section samples (type 20, 21, 22), the incorrect threshold gets divided back out again when interpolating on the energy / energy_threshold grid, so these are not affected.