[Hold] feat(imports): Add CmsBatchImport events #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
added
canary
damassi
force-pushed
the
damassi/feat/batch-import
branch
from
7631ab9 to
03f1aa2
Compare
damassi
commented
Feb 25, 2025
damassi
force-pushed
the
damassi/feat/batch-import
branch
3 times, most recently
from
b1ac220 to
7e4bc6d
Compare
damassi
commented
Feb 25, 2025
| * { | ||
| * context_module: "batchImportFlow", | ||
| * context_page_owner_type: "batchImport", | ||
| * context_page_owner_id: "67b646ecbe87376bfeb3f962", |
There was a problem hiding this comment.
Ditto here; where the partner is given the option to download we haven't yet generated an import ID. Cool if we pass an empty string here?
damassi
force-pushed
the
damassi/feat/batch-import
branch
from
7e4bc6d to
9deed32
Compare
damassi
commented
Feb 25, 2025
| * { | ||
| * event: "csvImportError", | ||
| * context_page_owner_type: "batchImport", | ||
| * context_page_owner_id: "67b646ecbe87376bfeb3f962", |
There was a problem hiding this comment.
☝️ If there's a (fatal) error during import we don't generate an ID.
If there's a warning, where some rows can be imported, we do have an ID.
damassi
force-pushed
the
damassi/feat/batch-import
branch
from
9deed32 to
139e039
Compare
damassi
changed the title
|
|
@damassi Amended the PR after reviewing what's available in the BE.
|
|
Sweet, thanks @leodmz. I'll rebase and merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
Description
This updates cohesion with the new BatchImports events.
Additionally (per our discussion @leodmz) starts organizing our CMS-specific events inside of an
src/Schema/CMSfolder, mirroring how things are structured in web / ios folders:An updated organization like this will become imperative as we continue migrating CMS pages to our modern patterns and moving legacy CMS events over to cohesion.
Note that CMS interfaces/events/values have been prefixed with a
CMSidentifier. This shouldn't preclude mixing in events from other parts of the schema in an event (likeEvent.click), only that now we can go directly to theCMSfolder not get lost in collector-specific events, and avoid type clashes.cc @artsy/amber-devs
PR Checklist (tick all before merging)
index.tsclickandtap(platform is inferred by the DB storing events)📦 Published PR as canary version:
4.238.1--canary.562.11138.0✨ Test out this PR locally via: