Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): ensures internal hardcoded http links are https for seo purposes #6391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dzucconi
Copy link
Member

While we currently redirect HTTP to HTTPS in production, our SEO reports flagged hard-coded HTTP links as an issue. This change automatically updates HTTP links found in markdown inputs to HTTPS, addressing all likely instances where these might appear.

@dzucconi dzucconi requested a review from a team January 28, 2025 13:29
@dzucconi dzucconi self-assigned this Jan 28, 2025
@artsy-peril
Copy link
Contributor

artsy-peril bot commented Jan 28, 2025


Warnings
⚠️ The V2 schema in this PR has breaking changes with Force. Remember to update the Force schema if necessary.

Argument 'initialArtworksIndexName: String' was removed from field 'Query.discoverArtworks'
Argument 'initialArtworksIndexName: String' was removed from field 'Viewer.discoverArtworks'

Generated by 🚫 dangerJS against 7df2037

Copy link
Contributor

@joeyAghion joeyAghion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK-ish but ideally any automatic transformation would happen at the back-end, where it could apply to other surfaces like app and maybe only have to run once instead of on each read.

@dzucconi
Copy link
Member Author

dzucconi commented Feb 5, 2025

@joeyAghion I mean, this is the backend? I do think this is the most appropriate place to catch it because it's just anything that touches Markdown.

However, I think we might be able to get away with a one-time task that just searches for these URLs throughout the database and updates them with the assumption that we're pretty much never going to see that happen again unless somebody manually types "http". The tricky part there is just the legwork to find all of the Markdown fields that it might be in and then managing to efficiently query them. Though we can do most of this just manually, and it certainly doesn't need to be fast.

@joeyAghion
Copy link
Contributor

This is... mid-end (?). Although you're right that this shared location can be leveraged by the mobile app as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants