-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/nats improvements #171
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 30.72% 31.08% +0.35%
==========================================
Files 127 127
Lines 24139 23854 -285
==========================================
- Hits 7416 7414 -2
+ Misses 16723 16440 -283 ☔ View full report in Codecov by Sentry. |
I tried to address the failing tests situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a little too much input for a proper review but I haven't seen anything that is obviously broken.
But it's great that you've also fixed the problem with the “randomly” failing tests 🙌
I refactored the slightly ugly solution to skip the inner loops in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @das-Abroxas too much to properly review. We should include refactoring only changes to separate PRs in the future.
Otherwise im fine with that. LGTM!
Summary
Adds missing event messages for server to server sync, additional bug fixes and improvements.
Changes
user_db_handler
,workspace_db_handler
andservice_accounts_db_handler
hook_handler
workspace_db_handler
andhooks_handler