Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unscaled active mode link count via vehicle link counts #239

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

syhwawa
Copy link
Contributor

@syhwawa syhwawa commented Feb 5, 2025

This PR addresses the issue in the scaling logic for link_vehicle_counts in Elara. Previously, the scaling logic only accounted for cars. Therefore, such as bike and walk were not properly scaled, resulting in inaccurate link counts when it was used for active mode.

The scaling logic has been updated to include all relevant modes ("car", "taxi", "bike", "walk") that require scaling when using this event handler.

The fix has been tested in the example simulation and the active mode account now should be scaled withthe config scale factor as expected.

bike count total sum before the fix: 95795.0
bike count total sum after the fix: 957950.0

The CI build pipeline is a bit out of date and it was updated to compatible version.

Proposed Testing Plan:
Write unit tests to validate the scaling logic for newly added mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaling factor logic in vehicle link count
1 participant