Fix unscaled active mode link count via vehicle link counts #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in the scaling logic for
link_vehicle_counts
in Elara. Previously, the scaling logic only accounted for cars. Therefore, such asbike
andwalk
were not properly scaled, resulting in inaccurate link counts when it was used for active mode.The scaling logic has been updated to include all relevant modes ("car", "taxi", "bike", "walk") that require scaling when using this event handler.
The fix has been tested in the example simulation and the active mode account now should be scaled withthe config scale factor as expected.
The CI build pipeline is a bit out of date and it was updated to compatible version.
Proposed Testing Plan:
Write unit tests to validate the scaling logic for newly added mode