Use reusable GitHub actions in CI build #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of creating small PRs, I'm splitting the fix for #88 into two PRs. This one introduces the reusable Slack notifications action as a replacement for the inlined equivalent in the CI build.
Once this is merged, I will replace the inlined step that uploads the zipped repo to S3. That second PR will be slightly more complex than this one because the current equivalent code does more than the reusable Action by also parsing the version info out of
pom.xmlbefore uploading to S3. It will require minor refactoring to move that into a dedicated step.Build notifications are still happening for this branch after the change to the build workflow: