[llm unify 5/n] llm_filter #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Lindeman <[email protected]>
…e use entity Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
…plan as map Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
baitsguy
reviewed
Feb 11, 2025
| @@ -317,7 +323,7 @@ def __init__(self, question: str, field: str, format: Optional[str], discrete: b | |||
| ) | |||
|
|
|||
|
|
|||
| class LlmFilterMessagesPrompt(SimplePrompt): | |||
| class _LlmFilterMessagesPrompt(SimplePrompt): | |||
| LlmFilterDocValuePrompt = FieldValuePrompt( | ||
| system="You are a helpful classifier that generously filters database entries based on questions.", | ||
| user=( | ||
| "Given a field value and a question, you will answer the question relating " |
There was a problem hiding this comment.
We can probably combine these? It's okay to rewrite this prompt to something better too since we're editing. I can help test
| def __init__(self): | ||
| super().__init__() | ||
|
|
||
|
|
||
| class JinjaDie(Exception): |
There was a problem hiding this comment.
Maybe name this differently :D
| @@ -219,6 +221,7 @@ def test_extract_entity_with_similarity_sorting(self, mocker): | |||
| assert (taken[0].elements[1]["properties"]["_element_index"]) == 2 | |||
|
|
|||
| # Element order should be changed in the prompt | |||
| print(taken[1]) | |||
| ) | ||
| comptransform = entity_extractor.as_llm_map(child) | ||
| assert isinstance(comptransform, CompositeTransform) | ||
| llm_map = comptransform.nodes[-2] |
There was a problem hiding this comment.
mind adding a couple comments to clarify what the expectation here is/why
Signed-off-by: Henry Lindeman <[email protected]>
baitsguy
approved these changes
Feb 11, 2025
austintlee
pushed a commit
that referenced
this pull request
Feb 14, 2025
* convert extract_properties to use LLMMap Signed-off-by: Henry Lindeman <[email protected]> * use _schema_name or _schema_class as output field if present otherwise use entity Signed-off-by: Henry Lindeman <[email protected]> * drop _prompts Signed-off-by: Henry Lindeman <[email protected]> * address pr comments Signed-off-by: Henry Lindeman <[email protected]> * make mypy happy Signed-off-by: Henry Lindeman <[email protected]> * put back original exception whoops Signed-off-by: Henry Lindeman <[email protected]> * initial llm filter translate Signed-off-by: Henry Lindeman <[email protected]> * ..source_element_index -> ..source_element_indices Signed-off-by: Henry Lindeman <[email protected]> * oh yeah this was supposed to get deleted Signed-off-by: Henry Lindeman <[email protected]> * deprecate docset.llm_filter Signed-off-by: Henry Lindeman <[email protected]> * add source indices for single batch element batcher Signed-off-by: Henry Lindeman <[email protected]> * get llm_filter uts working while using EntityExtractor.as_llm_map to plan as map Signed-off-by: Henry Lindeman <[email protected]> * fix uts that broke Signed-off-by: Henry Lindeman <[email protected]> * ruff Signed-off-by: Henry Lindeman <[email protected]> * mypy Signed-off-by: Henry Lindeman <[email protected]> * pr comments Signed-off-by: Henry Lindeman <[email protected]> --------- Signed-off-by: Henry Lindeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.