[llm unify 5c/n] jinjify extract properties #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
…adatadocs Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
…pting Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
dhruvkaliraman7
approved these changes
Feb 10, 2025
| ) | ||
|
|
||
| PropertiesFromSchemaJinjaPrompt = JinjaPrompt( | ||
| system="You are given text contents from a document.", |
There was a problem hiding this comment.
Is this the correct system prompt?
There was a problem hiding this comment.
afaict, yep.
| @@ -15,6 +15,7 @@ def _infer_prompts( | |||
| if llm_mode == LLMMode.SYNC: | |||
| res = [] | |||
| for p in prompts: | |||
| print(p) | |||
| if self._schema_name is not None: | ||
| prompt = prompt.set(entity=self._schema_name) | ||
| prompt = prompt.set(num_elements=self._num_of_elements) | ||
| if self._prompt_formatter is not element_list_formatter: | ||
| prompt = prompt.set(prompt_formatter=self._prompt_formatter) |
There was a problem hiding this comment.
Not setting for element_list_formatter because you're letting jinja fragments do the work? I'm assuming you would just remove element_list_formatter once you refactor LLM_schema_extractor?
There was a problem hiding this comment.
yep. will aim to drop it when it's no longer used
Signed-off-by: Henry Lindeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.