Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize query strings to avoid Ray Dataset column imputation #1171

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Serialize query strings to avoid Ray Dataset column imputation #1171

merged 2 commits into from
Feb 11, 2025

Conversation

austintlee
Copy link
Contributor

No description provided.

@austintlee austintlee requested a review from HenryL27 February 11, 2025 01:45
HenryL27
HenryL27 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@HenryL27 HenryL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all the other sycamore->sycamore transforms we use pickle -

sycamore/lib/sycamore/sycamore/data/document.py

Line 182 in 43758ca

def serialize(self) -> bytes:

I'll leave it to you whether to go pickle or json but just flagging. (some items aren't jsonable, but prob not an issue here?)

@austintlee austintlee merged commit 87f230e into main Feb 11, 2025
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryL27 HenryL27 HenryL27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austintlee @HenryL27