Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix None in llm response #1173

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix None in llm response #1173

merged 1 commit into from
Feb 11, 2025

Conversation

dhruvkaliraman7
Copy link
Contributor

If None is present as a value as part of llm response, json.loads() fails.

HenryL27
HenryL27 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@HenryL27 HenryL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. testing is optional. I know I didn't add one for the escape code change

@dhruvkaliraman7 dhruvkaliraman7 merged commit 8b06351 into main Feb 11, 2025
12 of 15 checks passed
@dhruvkaliraman7 dhruvkaliraman7 deleted the Load-json-bug branch February 11, 2025 21:06
austintlee pushed a commit that referenced this pull request Feb 14, 2025
@dhruvkaliraman7 @austintlee
Fix None in llm response (#1173)
531593c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryL27 HenryL27 HenryL27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvkaliraman7 @HenryL27