Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small update to field_to_value #620

Merged
merged 10 commits into from
Jul 31, 2024
Merged

Small update to field_to_value #620

merged 10 commits into from
Jul 31, 2024

Conversation

tranade
Copy link
Contributor

@tranade tranade commented Jul 30, 2024 •
edited
Loading

  • Make field_to_value return None as a default, if the field does not exist
  • Related updates in places this function is used

@tranade tranade marked this pull request as draft July 30, 2024 20:19
@tranade tranade marked this pull request as ready for review July 30, 2024 22:56
@tranade tranade requested a review from baitsguy July 30, 2024 23:01
@baitsguy
Copy link
Contributor

Looks like an integ test failures

@tranade tranade merged commit 493e336 into main Jul 31, 2024
9 of 10 checks passed
@tranade tranade deleted the tanvi/follow-up-changes branch July 31, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baitsguy baitsguy baitsguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tranade @baitsguy