Skip to content

🛠 fix: Change oembed to dynamic player #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

🛠 fix: Change oembed to dynamic player #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions lib/asciinema_web/views/oembed_view.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ defmodule AsciinemaWeb.OembedView do
max_height || image_height
)

recording_url = Routes.recording_url(Endpoint, :show, asciicast)
thumbnail_url = recording_url <> ".png"
script_url = Routes.recording_url(Endpoint, :show, asciicast) <> ".js"
script_id = "asciicast-#{asciicast.id}"

%{
type: "rich",
Expand All @@ -52,17 +52,14 @@ defmodule AsciinemaWeb.OembedView do
thumbnail_url: thumbnail_url,
thumbnail_width: width,
thumbnail_height: height,
html: html(recording_url, thumbnail_url, asciicast.title, width),
html: html(script_url, script_id),
width: width,
height: height
}
end

defp html(recording_url, thumbnail_url, title, width) do
safe =
content_tag(:a, href: recording_url, target: "_blank") do
img_tag(thumbnail_url, alt: title, width: width)
end
defp html(script_url, script_id) do
safe = content_tag(:script, src: script_url, id: script_id, async: true)

Phoenix.HTML.safe_to_string(safe)
end
Expand Down