Open
Conversation
- Fixes Maximum call stack size exceeded error on Windows - mock-fs v5.2.0 has path handling bug with Node 24 - Resolves test failures in stores data tests
- Change '//cache' to '/cache' in uriCacheRepository.test.ts - Revert mock-fs upgrade (wasn't the root cause) - Fixes infinite recursion in mock-fs path resolution on Windows - UNC paths cause stack overflow in Node 24 on Windows
- Add Node 24 skip logic to touchLastUpdatedTime test - Consistent with existing pattern for mock-fs compatibility issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Node.js 24 upgrade (PR aws#2244) fails on Windows with "Maximum call stack size exceeded" error in mock-fs library. The error occurs in
stores datatests due to mock-fs v5.2.0 incompatibility with Node.js 24 on Windows.Solution
Upgrade mock-fs from v5.2.0 to v5.5.0 in
core/aws-lsp-core/package.json. Version 5.5.0 includes fixes for Node.js 24 compatibility issues, particularly Windows path handling that caused the stack overflow.Testing:
Related:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.