make sure to raise error if service is unreachable (with or without a retry)

Author: darragh

lib/intercom.rb

@@ -53,12 +53,12 @@ def self.target_base_url
 
   def self.send_request_to_path(request)
     request.execute(target_base_url)
-  rescue Intercom::ServiceReachableError
+  rescue Intercom::ServiceReachableError => e
     if @endpoints && @endpoints.length > 1
-      @endpoints = @endpoints.rotate
       request.execute(target_base_url)
+    else
+      raise e
     end
-
   end
 
   def self.post(path, payload_hash)

spec/integration/intercom_api_integration_spec.rb

@@ -57,8 +57,14 @@
 
   it "should failover to good endpoint when first one is un-reachable" do
     Intercom.endpoints = ["http://127.0.0.7", "https://api.intercom.io"]
-
     user = Intercom::User.find(:email => "[email protected]")
     user.name.must_equal "Somebody"
   end
+
+  it "should raise error when endpoint(s) are un-reachable" do
+    Intercom.endpoints = ["http://127.0.0.7"]
+    proc { Intercom::User.find(:email => "[email protected]")}.must_raise Intercom::ServiceReachableError
+    Intercom.endpoints = ["http://127.0.0.7", "http://127.0.0.6"]
+    proc { Intercom::User.find(:email => "[email protected]")}.must_raise Intercom::ServiceReachableError
+  end
 end