Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced Code Duplication #107

Merged

Conversation

Abh-I-seK
Copy link
Contributor

Issue Title: Reducing Code Duplication

resolve issue: #59

Type of change ☑️

What sort of change have you made:
I made a component which I used to display the image icons in the home page. Previously each icon had its own image component coded, which resulted in a large part of the code being repeated.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙️

I tested my code locally by comparing it with the version which is currently deployed.

Copy link

Thank you for submitting this pull request.
We will review the changes and get in contact with you as soon as possible.

Copy link
Owner

@ashutoshgithubs ashutoshgithubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Abh-I-seK This PR is good to merge.

@ashutoshgithubs ashutoshgithubs merged commit 0cedcac into ashutoshgithubs:DevG_Contribute May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants